1
0
Commit Graph

4458 Commits

Author SHA1 Message Date
Ahmed Bouhuolia a9d2316fc2 Merge pull request #1093 from bigcapitalhq/fix/attachment-tenant-isolation
fix(server): prevent cross-tenant attachment access (IDOR)
2026-05-15 14:54:19 +02:00
Ahmed Bouhuolia e18e61000d fix(server): prevent cross-tenant attachment access (IDOR)
Add tenant-scoped document lookup with throwIfNotFound() before S3
operations in GetAttachment, DeleteAttachment, and
GetAttachmentPresignedUrl services. This prevents users from reading,
deleting, or generating presigned URLs for attachments belonging to
other tenants.

Also adds RequirePermission decorators to the three attachment
endpoints and introduces Attachment ability subject with View and
Delete actions.

GHSA-rc4v-wq22-v6cf

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-15 14:47:18 +02:00
Ahmed Bouhuolia 3c87abd34e Merge pull request #1091 from bigcapitalhq/chore/update-openapi-sdk-types
chore(sdk): update OpenAPI spec and generated types
2026-05-12 18:24:55 +02:00
abouolia 66ffff5b8d chore(sdk): update OpenAPI spec and generated types 2026-05-12 08:56:28 +00:00
Ahmed Bouhuolia f8afa00f29 Merge pull request #1089 from c-premus/fix/dynamic-filter-pagination 2026-05-12 10:53:54 +02:00
Ahmed Bouhuolia f3cb3b9722 Merge pull request #1090 from rebekah-create/fix/liabilties-typo 2026-05-12 08:53:45 +02:00
rebekah-create 3cbc4842b9 fix(server): correct "Liabilties" typo to "Liabilities" in balance sheet
The balance sheet rendered "Current Liabilties" in the Liabilities
section because of a typo in the i18n key, the schema reference, the
swagger example responses, and the generated SDK fixtures. Fixed all
five locations so PDF/HTML/JSON renders all read "Current Liabilities".

- packages/server/src/i18n/en/balance_sheet.json: rename key and value
- packages/server/src/modules/FinancialStatements/modules/BalanceSheet/
  BalanceSheetSchema.ts: update i18n key reference
- packages/server/src/modules/FinancialStatements/modules/BalanceSheet/
  BalanceSheet.swagger.ts: fix three example response strings
- shared/sdk-ts/openapi.json + schema.ts: regenerate to match
2026-05-12 00:10:44 -04:00
Chris 46012a1b1c Fix pagination params silently ignored on collection GET endpoints
Hoist `page` and `pageSize` declarations from the per-module DTOs into
the shared DynamicFilterQueryDto base class. Without these declarations,
the global ValidationPipe (whitelist: true) strips the params from the
request before the service layer sees them, so list services fall back
to their default page=1, pageSize=12 regardless of what the client sent.

Affects 10 collection GET endpoints whose query DTOs are empty subclasses
of DynamicFilterQueryDto: expenses, bills, credit-notes, manual-journals,
payments-received, sale-invoices, sale-estimates, sale-receipts,
vendor-credits, item-categories.

The 3 already-working DTOs (Customers, Vendors, Items) keep their local
page/pageSize declarations as redundant overrides — no behavior change.

Closes #1088
2026-04-29 11:51:49 +00:00
Ahmed Bouhuolia 52c97f1401 Merge pull request #1075 from bigcapitalhq/fix/export-i18n-column-headers
fix(server): localize i18n column headers in CSV/XLSX/PDF exports
2026-04-13 18:37:38 +02:00
Ahmed Bouhuolia 3db9061c60 fix(server): localize i18n column headers in export (CSV/XLSX/PDF)
Export column headers displayed raw i18n keys like
`expense.field.payment_account` instead of translated names like
"Payment Account" because ExportResourceService never resolved the
i18n keys before rendering.

Inject I18nService and translate column names in both
getExportableColumns() (CSV/XLSX) and getPrintableColumns() (PDF).

Closes #1073

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-13 18:32:24 +02:00
Ahmed Bouhuolia 37d5546763 Merge pull request #1074 from bigcapitalhq/fix/financial-reports-base-currency
fix(server): use correct base currency in financial reports
2026-04-13 17:58:19 +02:00
Ahmed Bouhuolia a7a0a7fbe7 fix(server): use correct base currency in financial reports
Reports (Receivable Aging Summary, Payable Aging Summary, Inventory
Valuation, Sales Tax Liability Summary, Vendor Balance Summary) were
not assigning baseCurrency from meta in their constructors, causing
currency formatting to fall back to USD instead of the organization's
base currency.

Closes #1069

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-13 17:52:46 +02:00
Ahmed Bouhuolia 5944aa3972 Merge pull request #1063 from Y8C68/fix/attachment-content-type 2026-04-03 09:16:08 +02:00
Y8C68 dd58f50387 fix(server): handle missing ContentType in attachment download
GET /api/attachments/:id crashes with "Cannot read properties of
undefined (reading extension)" when the S3 object has no ContentType
metadata. This happens when files are uploaded without explicit content
type (e.g., via API integrations).

mime.extension(undefined) returns undefined, which then causes the
Content-Disposition header template to fail.

Fix: fallback to "application/octet-stream" when ContentType is missing,
and "bin" when mime.extension() returns undefined.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-03 06:11:28 +00:00
Ahmed Bouhuolia e9747f4f9e Merge pull request #1056 from bigcapitalhq/chore/webapp-format-script
chore(webapp): add Prettier format and format:check scripts
v0.25.20
2026-03-27 18:24:29 +02:00
Ahmed Bouhuolia ccb34e2155 chore(webapp): add format and format:check scripts
Add Prettier scripts to webapp package for code formatting, consistent
with the existing server package setup.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-27 18:21:23 +02:00
Ahmed Bouhuolia 1c93244801 Merge pull request #1055 from bigcapitalhq/chore/update-openapi-sdk-types 2026-03-27 17:43:51 +02:00
abouolia 2492a5b043 chore(sdk): update OpenAPI spec and generated types 2026-03-27 14:37:15 +00:00
Ahmed Bouhuolia b0db59a495 feat(webapp): customer/vendor form ux improvement (#1053)
* feat(webapp): customer/vendor form ux improvement
2026-03-27 16:34:52 +02:00
rmb 580392a408 fix: bulk uncategorize transactions API endpoint (#1054)
* fix: bulk uncategorize transactions - fix API endpoint and error handling

* refactor: use params object instead of URLSearchParams for delete request

Simplifies the API call by passing params object directly to the delete
method instead of manually building URLSearchParams.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Ahmed Bouhuolia <a.bouhuolia@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-27 16:30:19 +02:00
Ahmed Bouhuolia a1d1f53773 fix: typescript errors 2026-03-27 16:29:44 +02:00
Ahmed Bouhuolia f5d1800c8c wip 2026-03-27 16:11:33 +02:00
Ahmed Bouhuolia 4dc5c5abe0 wip 2026-03-27 13:14:54 +02:00
Ahmed Bouhuolia d5cc3d1a71 wip 2026-03-27 11:29:57 +02:00
Ahmed Bouhuolia 50ba91ecf1 fix 2026-03-27 09:57:03 +02:00
Ahmed Bouhuolia 5ba753e808 wip 2026-03-27 01:08:57 +02:00
Ahmed Bouhuolia 2e90e3cc5b wip 2026-03-26 18:04:33 +02:00
Ahmed Bouhuolia 8b59f28125 wip 2026-03-26 17:40:24 +02:00
Ahmed Bouhuolia aa89484b64 wip 2026-03-26 14:59:45 +02:00
Ahmed Bouhuolia 75699ba810 wip 2026-03-26 14:18:54 +02:00
rmb ad0451f32d fix: resolve double slash issue in report print functionality (#1051)
* fix print button for report tab modules

* fix: resolve double slash in report print URLs - Revert ChromiumlyTenancy changes
2026-03-26 09:52:26 +02:00
Ahmed Bouhuolia 8f1af97fc0 feat(webapp): customer/vendor form ux improvement 2026-03-24 21:21:50 +02:00
Ahmed Bouhuolia cfbfc0b746 fix(accounts): correct typos in account type constants (#1046)
- Fix 'none-current-asset' -> 'non-current-asset' in ACCOUNT_TYPE
- Fix 'non-ACCOUNT_PARENT_TYPE.CURRENT_ASSET' -> 'non-current-asset' copy-paste error
- Fix 'expene' -> 'expense' typo in ACCOUNT_ROOT_TYPE
- Add database migration to update existing records

Fixes #1041

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
v0.25.19
2026-03-16 02:34:41 +02:00
Ahmed Bouhuolia 5caa4bce61 Merge pull request #1045 from bigcapitalhq/self-contained-e2e-github-action
feat(ci): self contained e2e GitHub action
2026-03-15 23:49:49 +02:00
Ahmed Bouhuolia ec17514d49 Merge pull request #1043 from bigcapitalhq/chore/update-openapi-sdk-types
chore(sdk): update OpenAPI spec and generated types
2026-03-15 21:32:13 +02:00
Ahmed Bouhuolia 68e4dd67af Merge pull request #1044 from bigcapitalhq/ci/generate-openapi-workflow
feat(ci): Ci/generate openapi workflow
2026-03-15 21:31:35 +02:00
abouolia 95aa03ac25 chore(sdk): update OpenAPI spec and generated types 2026-03-15 19:30:03 +00:00
Ahmed Bouhuolia be61488952 fix(ci): add MySQL and Redis services for OpenAPI generation
The NestJS app requires database and Redis connections to bootstrap.
Added GitHub Actions services for MySQL and Redis with necessary
environment variables for the openapi:export command to work.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 21:27:24 +02:00
Ahmed Bouhuolia 2358ef9097 fix(ci): build shared packages before OpenAPI generation
The server depends on @bigcapital/email-components and other shared
packages. Build them before running openapi:export to fix module
resolution errors.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 21:19:03 +02:00
Ahmed Bouhuolia b1a5f3c2e4 Merge pull request #1040 from bigcapitalhq/querydto2
feat(server): add Query DTOs for consistent filtering across modules
2026-03-15 21:16:03 +02:00
Ahmed Bouhuolia 9b31210f6d wip 2026-03-15 21:14:27 +02:00
Ahmed Bouhuolia 7034be0fe7 Merge pull request #1042 from bigcapitalhq/ci/generate-openapi-workflow
ci: add GitHub Action to auto-generate OpenAPI SDK types
2026-03-15 16:24:05 +02:00
Ahmed Bouhuolia 5c32f41f22 ci: add GitHub Action to auto-generate OpenAPI SDK types
Adds workflow that triggers on server code changes to:
- Export OpenAPI spec from NestJS Swagger module
- Generate TypeScript types with openapi-typescript
- Build the SDK package
- Create PR with changes if any exist

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 16:22:50 +02:00
Ahmed Bouhuolia 2f45263263 feat(server): add Query DTOs for consistent filtering across modules
- Add GetBillsQuery.dto.ts, GetCreditNotesQuery.dto.ts, GetExpensesQuery.dto.ts
- Add GetItemCategoriesQuery.dto.ts, GetManualJournalsQuery.dto.ts
- Add GetPaymentsReceivedQuery.dto.ts, GetSaleEstimatesQuery.dto.ts
- Add GetSaleInvoicesQuery.dto.ts, GetSaleReceiptsQuery.dto.ts, GetVendorCreditsQuery.dto.ts
- Update DynamicFilterQuery.dto.ts with enhanced filter options
- Refactor controllers and services to use new Query DTOs
- Update SDK schema and sale-estimates types

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 08:50:15 +02:00
Ahmed Bouhuolia 6a2edd9417 Merge pull request #1039 from bigcapitalhq/settings-hooks
feat(sdk-ts): settings fetch utils
2026-03-14 23:31:14 +02:00
Ahmed Bouhuolia 8685d7ef18 feat(sdk-ts): settings fetch utils 2026-03-14 23:24:31 +02:00
Ahmed Bouhuolia 5cf528cebc Merge pull request #1037 from bigcapitalhq/refactor/exchange-rates-nestjs
refactor(server): migrate ExchangeRates module to NestJS
2026-03-14 05:22:04 +02:00
Ahmed Bouhuolia eff5f6b9f7 feat(sdk-ts): add exchange-rates SDK functions
- Add fetchLatestExchangeRate function to retrieve exchange rates
- Add ExchangeRateLatestQuery and ExchangeRateLatestResponse types
- Export exchange-rates module from SDK index
2026-03-14 05:20:12 +02:00
Ahmed Bouhuolia 3706e048b6 refactor(server): migrate ExchangeRates module to NestJS
- Convert TypeDI services to NestJS @Injectable() pattern
- Replace Express router with NestJS @Controller() decorators
- Migrate express-validator to class-validator DTOs
- Add Swagger/OpenAPI documentation decorators
- Fix import paths for TenantMetadata and ServiceError
- Add ExchangeRatesModule to AppModule imports
2026-03-14 05:16:06 +02:00
Ahmed Bouhuolia 6515bd2a60 Merge pull request #1035 from bigcapitalhq/feat/abouolia/credit-note-resource-sdk-dtos
feat: add response DTOs for CreditNoteRefunds and Resource modules
2026-03-10 23:35:44 +02:00